Repository navigation
Control unit - passed lvl 1 test - #33
Merged
Merged
Conversation
wando-dragon
requested review from
Guardian-Monkey and
Hans1021
as code owners
November 2, 2026 07:48
Contributor
|
add the #'s of issues closed by this to the PR description please |
Hans1021
approved these changes
Nov 2, 2026
Hans1021
left a comment
Hans1021
left a comment
Member
There was a problem hiding this comment.
Good work, I believe it's all correct, just painfully verbose since every control signal is listed for every instruction. We could just use the default assignments and have each instruction override the signals that differ, but this is fine for now. Thank you!
Contributor
Author
|
I can revise it later this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Unsure how ECALL/EBREAK was suppose to be approached so I made them NOP for now
-Passed lvl 1 test
-Closes #3